Hi On Tue, Feb 4, 2014 at 1:16 PM, Hans de Goede <[email protected]> wrote: > Hi, > > On 02/04/2014 01:03 PM, Mark Kettenis wrote: >>> From: Hans de Goede <[email protected]> >>> Date: Tue, 4 Feb 2014 12:49:10 +0100 >>> >>> With systemd-logind support, the xserver, rather then the drivers will be >>> responsible for opening/closing the fd for input devices. >>> >>> This commit adds a new capabilities field to the InputDriverRec and a >>> XI86_DRV_CAP_SERVER_FD flag for drivers to indicate that they support server >>> managed fds. >>> >>> This commit adds a new XI86_SERVER_FD flag to indicate to drivers when the >>> server is managing the fd and they should not open/close it. Note that even >>> if drivers declare they support server managed fds there is no guarantee >>> they >>> will actually get them. >>> >>> Since this changes the input driver ABI, this commit bumps it. >>> >>> systemd-logind tracks devices by their chardev major + minor >>> numbers, since we are breaking ABI anyways also add major and minor >>> fields for easy storage / retreival of these. >> >> Isn't the proper type to keep track of devices a dev_t? > > The systemd-logind API uses separate major and minor numbers rather then > a dev_t. Also I don't want to leak the platform specific dev_t type into > public > headers.
..and dev_t might be 32bit or 64bit depending on the architecture, which is awful for public APIs. Regards David _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
