The functions in xserver/render/glyph.c (and also in render.c) use external crypto library sha1 algorithm for a HashMap (of glyphs). This is the only occurance of x_sha1_* usage in xserver.
The x_sha1_* functions depend on external library (of packager choosing: openssl/libgcrypt/libnettle/other). 300 lines of code only to wrap external library calls. In those 300 lines one could write some simpler, faster hashmap hash function (isn't crc32 or something simpler good enough for this?), or one could copy the entire code for sha1 from another library. Depending on external crypto library because of a hashmap is insane for Christ's sake. I have also created a bug report for this: https://bugs.freedesktop.org/show_bug.cgi?id=79794 Marek Behun
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
