Rob Clark <robdcl...@gmail.com> writes: > On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt <e...@anholt.net> wrote: >> Rob Clark <robdcl...@gmail.com> writes: >> >>> For example, in the PolyFillRect() path w/ nrect==0, we end up in >>> glamor_get_vbo_space(size=0): >> >> I wonder instead if we shouldn't just have glamor_get_vbo_space() return >> NULL on size == 0? > > that was my first approach, and is a much smaller patch, but triggers > GL errors on glamor_put_vbo_space().. so with that approach we'd > either need some bookkeeping to skip the glUnmapBuffer() or live w/ > extra gl errors..
Might be good to do both in case we end up there again; a gl error is a better result than a segfault? -- -keith
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
