Daniel Stone <dan...@fooishbar.org> writes: > On 17 June 2017 at 02:21, Eric Anholt <e...@anholt.net> wrote: >> With the Present extension, we started putting CARD64s on the wire. >> Let's use them here, too. > > Mm, we did have that originally, but anyone including XSync headers > very helpfully gets #define CARD64 XSyncValue, which blows up into int > + unsigned int. This includes dri3_request.c, which pulls in syncsrv.h > -> misyncstr.h: > ../../dri3/dri3_request.c: In function ‘proc_dri3_get_supported_modifiers’: > ../../dri3/dri3_request.c:407:23: error: invalid initializer > CARD64 modifier = 0; > ^ > ../../dri3/dri3_request.c:431:6: error: conversion to non-scalar type > requested > modifier = (CARD64) (modifiers_hi[i] << 32); > ^~~~~~~~ > > I'd originally thought that came from the server-only part of > xexxtproto/syncstr.h, but turns out it's actually just in > miext/sync/misyncstr.h. So I guess we could run s/CARD64/XSyncValue/ > across sync, but it would (at least theoretically) be an API break.
I took a look at that, and it seems like a good plan. Would you be up for taking care of it, or should I put it on my list? (Though, really, I wish CARD* would die in a fire. We have stdint now.)
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
