On 06/08/17 07:16, Aaron Plattner wrote: > On 08/05/2017 08:02 AM, Antoine Martin wrote: >> On 17/12/16 02:04, Emil Velikov wrote: >>> Hi Bob, >>> >>> On 9 December 2016 at 22:25, Bob Terek <x...@esoterek.com> wrote: >>>> >>>> On 12/09/2016 03:13 AM, Emil Velikov wrote: >>>> >>>>> On 6 December 2016 at 22:41, Bob Terek <x...@esoterek.com> wrote: >>>>>> >>>>>> Resubmitting some of Aaron Plattner's cleanup patches to >>>>>> xf86-video-dummy: >>>>>> >>>>>> https://lists.x.org/archives/xorg-devel/2015-January/045395.html >>>>>> . . . >>>>>> . . . >>>> >>>> >>>>> Afaict the patches are literally unchanged since Aaron's submit. As >>>>> such changing the authorship is a bit ... bad. >>>> >>>> >>>> Oops, sorry for the breach in protocol. Do I need to do something specific >>>> to "withdraw" the patch I sent? Should I do something at Patchwork? >>>> >> I've restored the "author" and added Bob as "Reviewed-by" instead. >> >>> Updating patchwork would be very good, indeed. >>> >>>> I'm going to submit an alternative approach to Aaron's 6/6, and was going >>>> to include the remaining cleanups, but then it was thought the cleanups >>>> should be addressed separately. So then for some reason I thought they >>>> needed to be submitted again, against the current version. . . >>>> >>> Agreed. >> These patches have been reviewed and tested quite a few times now. >> I've just created a git repo with all the uncontroversial pending >> changes to the dummy driver, 6 so far: >> https://github.com/totaam/xf86-video-dummy/commits/master >> What else can I do to help move this along? > > I've pushed all of these except "support for 30 bit depth in dummy driver". I > want to check that changing the colormap size to 1024 for depth 24 doesn't > change behavior. Thanks!
FWIW: I am reasonably confident that the 30-bit patch is safe as we've been shipping it in the Fedora, CentOS, Debian and Ubuntu repositories for a while. If X11 applications were suddenly to break because of it, I would have heard the complaints by now. Antoine > > remote: Updating patchwork state for > https://patchwork.freedesktop.org/project/Xorg/list/ > remote: I: patch #41059 updated using rev > 12e3e2030171b7a5df074a56293eb16da40cd99b. > remote: I: patch #41060 updated using rev > 7c3b090e80a9b364434120262f9bef5686cd2e2e. > remote: E: failed to find patch for rev > 87249af5faf85c8d093e910c069faa4db0aee843. > remote: I: patch #125912 updated using rev > 33e68185665b2d065525ac03332f080026b18d8d. > remote: I: patch #168436 updated using rev > 7957ad83b53b57f376164b10742d4e35223c9dcc. > remote: E: failed to find patch for rev > 5e90221dc68ae0893acd5c9b12d702269202558d. > remote: I: 4 patch(es) updated to state Accepted. > To git.freedesktop.org:/git/xorg/driver/xf86-video-dummy > af0f808922f2..5e90221dc68a master -> master > > >> Thanks >> Antoine >> >> >> >> >>> >>> Thanks >>> Emil >>> _______________________________________________ >>> xorg-devel@lists.x.org: X.Org development >>> Archives: http://lists.x.org/archives/xorg-devel >>> Info: https://lists.x.org/mailman/listinfo/xorg-devel >>> >> >> _______________________________________________ >> xorg-devel@lists.x.org: X.Org development >> Archives: http://lists.x.org/archives/xorg-devel >> Info: https://lists.x.org/mailman/listinfo/xorg-devel >> > _______________________________________________ > xorg-devel@lists.x.org: X.Org development > Archives: http://lists.x.org/archives/xorg-devel > Info: https://lists.x.org/mailman/listinfo/xorg-devel > _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel