Alex Goins <ago...@nvidia.com> writes:

> Adding Keith, as this is a regression that completely breaks PRIME Sync 
> configs
> at top of tree.

Adam asked me to look at this last week, and I'm afraid I've not had a
chance as I've been traveling. Thanks for the reminder. Reading through
the original patch, I agree that the new ms_queue_vblank function fails
to treat the relative sequence case correctly. And your fix does present
the correct information to the kernel.

Your patch also highlights a further bug in this code -- the call to
ms_drm_abort_seq is passing 'msc' instead of 'seq'. That only happens in
an error case, which probably means approximately never.

For your patch:

Reviewed-by: Keith Packard <kei...@keithp.com>

-- 
-keith

Attachment: signature.asc
Description: PGP signature

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to