On Wed, Apr 18, 2018 at 3:33 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > On Thursday 12 April 2018 16:34:15 Adam Jackson wrote: >> This should print the RANDR data in a separate stanza after the main >> output, like the other extensions do. Again: the purpose of the core of >> xdpyinfo is to tell you what the connection block says. Don't make it >> print something else. > > This patch does not change anything in the output when command line > option for RANDR is not used. Therefore you would get same output as > before (without applying patch). > > And when RANDR is explicitly requested then it outputs correct dimension > information. Yes, it hides what is reported by connection block, but the > main problem is that this tools is not already used like you said. Users > and also scripts expects that they would get correct monitor/output > dimension from xdpyinfo and not something which do not match with their > physical monitor device. > > As Giuseppe said, this seems like a good compromise. When no parameter > is specified then xdpyinfo reports exactly same data as without this > patch. And with this patch which adds support for optional RANDR > parameter, then it reports dimensions for each monitor/output correctly. > So users would see what they are already expecting and want.
No, in the RANDR case you are still replacing the core output, which is not what I suggested. Instead, the RANDR information should be provided _separately_ and _in addition to_ the core output. So instead of defining a useless print_none_info, put the RANDR code in print_randr_info and add _that_ to the known_extensions array. -- Giuseppe "Oblomov" Bilotta _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel