* Michel Dänzer <mic...@daenzer.net> [180706 07:48]: > On 2018-07-05 05:42 PM, Tony Lindgren wrote: > > Hi, > > > > * Michel Dänzer <mic...@daenzer.net> [180705 14:21]: > >> > >> This uses the same damage region for all framebuffers, which is > >> generally not correct for drmmode_crtc->rotate_fb_id. The coordinate > >> offset, rotation and reflection need to be taken into account for that. > > > > Hmm OK. I thought we just need to refresh it we have > > rotate_fb_id. > > > > Unfortunately I have no idea what the check here might be > > for the variables above.. Sounds like it might leave out > > some pointless updates though :) Care to describe a bit > > more or ideally even provide a patch to test? > > The simplest solution is probably to use separate damage records > attached to the per-CRTC rotation pixmaps.
Sorry but I still have no idea what needs to be checked with rotate_fb_id and rotation pixmaps before updating the display.. Regards, Tony _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
