On Tue, Dec 18, 2018 at 3:16 PM Kevin Brace <kevinbr...@gmx.com> wrote: > > Hi Alan, > > I am not asking to change the ABI. > I just spotted an inconsistency in how ScreenWakeupHandlerProcPtr is defined > inside compat-api.h and scrnintstr.h. > That appears the root of the problem. > I consider this a bug. > If I apply the patch to X Server's header file, the warning goes away. > > Proof: > > https://cgit.freedesktop.org/xorg/driver/xf86-video-savage/tree/src/compat-api.h?id=dce59663ecd846831724d6d7303ee813fa458a7d > (Line 85) > > https://cgit.freedesktop.org/xorg/xserver/tree/include/scrnintstr.h?h=server-1.19-branch&id=ebfb06b11955a6c32500b7086be912ab96b753a7 > (Line 280 and 281) > > > It appears that only xf86-video-savage is affected by this mismatch.
Why isn't the solution to change the definition of WAKEUPHANDLER_ARGS_DECL in -savage to be #define WAKEUPHANDLER_ARGS_DECL ScreenPtr arg, int result SAVAGEWakeupHandler doesn't even use the result param, so... seems safe. _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
