I've gone ahead and put up a merge request for review with both patches in:
https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/173
Thanks for these fixes,
-alan-
On 11/30/22 16:50, Alan Coopersmith wrote:
It looks like we updated the Workflow Overview section at the beginning
to mention "Create a merge request in the freedesktop.org gitlab", but
someone still needs to update the later sections of the document to cover
that and remove the email instructions. Sorry about the confusion here.
-alan-
On 11/30/22 15:47, Ulrich Sibiller wrote:
Well, then the documentation is wrong, I tried to follow this:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches/
<https://www.x.org/wiki/Development/Documentation/SubmittingPatches/>
which clearly talks about sending patches to the ML, but at the same time
mentioning gitlab without mentioning merge requests. Would have preferred a
gitlab MR instead of this ML hassle... ;-)
Uli
On Thu, Dec 1, 2022 at 12:37 AM Alan Coopersmith <alan.coopersm...@oracle.com
<mailto:alan.coopersm...@oracle.com>> wrote:
On 11/30/22 14:42, Ulrich Sibiller wrote:
> Resent due to gmail mangling tabs.. Seems impossible nowadays to send a
plaintext mail unmodifed using gmail's web interface...
Just one of many reasons we prefer patches to be sent as merge requests on
https://gitlab.freedesktop.org/xorg/lib/libx11
<https://gitlab.freedesktop.org/xorg/lib/libx11> instead. We can handle
emailed patches if using gitlab is a problem for you, but then we have
to be extra careful to make sure it doesn't get mangled at any point
along the way.
-- -Alan Coopersmith- alan.coopersm...@oracle.com
<mailto:alan.coopersm...@oracle.com>
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
<https://blogs.oracle.com/solaris>
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - https://blogs.oracle.com/solaris
