On Wed, 2011-11-16 at 23:07 +0200, Martin-Éric Racine wrote:

> I really would avoid moving the driver to its own directory. Other
> than that, these patches look promising. :)
> 
> 
> 

Any particular reasons why not? I know this is a bit of a shocker, but
having multiple targets in a makefile is error prone. The command to
build the ztv driver is all wrong. Leaving it in the same makefile will
just make it worse. When ever someone changes AM_CFLAGS, it applies to
ztv as well and no one would even think about it.

The first patch was just to move as I don't want to change many too
things at once. I have a few patches to follow-up and fix the makefile
to be correct for ztv. We can reassess after that and I can move it back
if need be.

Thanks.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xorg-driver-geode mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-geode

Reply via email to