On Tue, Mar 02, 2010 at 04:29:41PM -0800, Dan Nicholson wrote: > On Tue, Mar 2, 2010 at 4:16 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: > > On Tue, Mar 02, 2010 at 02:47:22PM -0800, Dan Nicholson wrote: > >> Can you try the patch below that uses the name attribute instead of the > >> value from the uevent? I ran it through a little test app, but not in X. > >> > >> From c01a4e6dce7196a60b5247dde78054b27e004494 Mon Sep 17 00:00:00 2001 > >> From: Dan Nicholson <dbn.li...@gmail.com> > >> Date: Tue, 2 Mar 2010 14:42:22 -0800 > >> Subject: [PATCH] config/udev: Get product name from attribute instead of > >> uevent > >> > >> The input device product name in the kernel uevent has embedded quotes > >> that aren't expected here. Use the sysfs name attribute instead, which > >> does not suffer this problem. > >> > >> Signed-off-by: Dan Nicholson <dbn.li...@gmail.com> > >> --- > >> config/udev.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/config/udev.c b/config/udev.c > >> index 69257e9..54306ef 100644 > >> --- a/config/udev.c > >> +++ b/config/udev.c > >> @@ -74,7 +74,7 @@ device_added(struct udev_device *udev_device) > >> > >> parent = udev_device_get_parent(udev_device); > >> if (parent) > >> - name = udev_device_get_property_value(parent, "NAME"); > >> + name = udev_device_get_sysattr_value(parent, "name"); > >> if (!name) > >> name = "(unnamed)"; > >> else > >> -- > >> 1.6.6.1 > > > > Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> > > > > tested too. > > Is this on rawhide with udev-151? When I tried it against the udev on > f12, it was replacing the spaces in the name with underscores. I can't > figure out why, but when I ran it against a vanilla udev 145 or git, > it worked fine.
This was on F12 (X server from git) and I don't see the underscore issue you mentioned. Updates-testing from yesterday. Not quite sure where that comes from tbh. Cheers, Peter _______________________________________________ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg