On Mon, 2 Aug 2010 11:29:55 -0400, Kristian Høgsberg <k...@bitplanet.net> wrote: > > Here's the other approach for fixing damage vs flush client. In writing the > commit message, it certainly does feel like damage should just be fixed to > not reply on that behaviour. And writing the patch, I realize that the > optimization is not just about saving a syscall, but also about avoiding > having to realloc the output buffer to hold a request that's bigger than > BUFSIZE (hello, XkbSendMap()). The current code only does that when it > fails to write the output buffer + extra request and the remaining bytes > don't fit in a standard sized buffer.
This doesn't really fix the issue as we're potentially sending a stream of events from the damage extension. We'd have to buffer all of them until FlushAllOutput, I think. It is a nice cleanup though; let's look at this post-1.9 separately. -- keith.pack...@intel.com
pgpFG3aiNnfqF.pgp
Description: PGP signature
_______________________________________________ xorg@lists.freedesktop.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg Your subscription address: arch...@mail-archive.com
