On Sun, 2010-11-28 at 15:47 +0100, Jan Engelhardt wrote: > Signed-off-by: Jan Engelhardt <jeng...@medozas.de> > --- > autogen.sh | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/autogen.sh b/autogen.sh > index 904cd67..90d2520 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -1,12 +1,12 @@ > #! /bin/sh > > -srcdir=`dirname $0` > +srcdir=`dirname "$0"` > test -z "$srcdir" && srcdir=. > > ORIGDIR=`pwd` > -cd $srcdir > +cd "$srcdir" > > autoreconf -v --install || exit 1 > -cd $ORIGDIR || exit $? > +cd "$ORIGDIR" || exit $? > > -$srcdir/configure --enable-maintainer-mode "$@" > +exec "$srcdir/configure" --enable-maintainer-mode "$@"
I am not expert in quoting, can you explain how this is more appropriate? If it is, then all other autogen.sh should be changed as well. I am always looking for improvement.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ xorg@lists.freedesktop.org: X.Org support Archives: http://lists.freedesktop.org/archives/xorg Info: http://lists.freedesktop.org/mailman/listinfo/xorg Your subscription address: arch...@mail-archive.com