Hi Edward, 

thanks for pointing this stuff out. (I'm not directly involved with xournal 
but the Gentoo maintainer.)

About the patches:

* add_ldflags: yes, makes (partially) definitely sense- this fixes most likely 
the underlinking issue also reported at 
https://bugs.gentoo.org/show_bug.cgi?id=372119
"--as-needed" should be added by the build system though, not in the Makefile.

* xoprint-len_fix: Denis already applied that in CVS head

* compilation_flags: this looks pretty distribution-specific to me

* correct_gtk_usage: Are you sure this one is still needed? It fixes a failure 
with ancient gtk+ 2.14.7; Gentoo runs absolutely fine without it... as far as 
I can see it is also not applied anymore in recent debian.

Cheers, 
Andreas

> Hello folks,
> 
> Xournal should probably look at taking some of the patches distributions
> are shipping with Xournal.  In particular, Ubuntu has one patch which
> fixes annotated PDF display on Oneiric (the PDF doesn't show up
> otherwise.)
> 
> You can grab them here:
> 
>    
> http://archive.ubuntu.com/ubuntu/pool/universe/x/xournal/xournal_0.4.5-3.d
> ebian.tar.gz



-- 

Andreas K. Huettel
Gentoo Linux developer 
[email protected]
http://www.akhuettel.de/

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Xournal-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xournal-devel

Reply via email to