On Sat, 13 Apr 2002, Dr Andrew C Aitchison wrote:

> > > I'm having problems with the patch
> > >   xc/programs/xterm/main.c,v 3.148 2002/04/10 16:20:09 tsi

> > OK, I'll back it out.

> Thanks for changing it, but:

> main.c: In function `spawn':
> main.c:2958: parse error before `int'
> main.c:2964: `pty_name' undeclared (first use in this function)
> main.c:2964: (Each undeclared identifier is reported only once
> main.c:2964: for each function it appears in.)
> main.c:2965: `ptyfd' undeclared (first use in this function)

> I think the problem is that line 2948
>       (void)setsid();
> is not an initialisation.

> I thought about changing
>       #ifdef USE_ISPTS_FLAG
>               if (IsPts) {    /* SYSV386 supports both, which did we open? */
>       #endif
> to
>       #ifdef USE_ISPTS_FLAG
>               if (IsPts)      /* SYSV386 supports both, which did we open? */
>       #endif
>               {
> (and the matching "} else {" and "}"), but I decided that this is too
> much of a twisty maze of paths and would somtimes change the scope of
> variables.
> Maybe it is better to stick with code which has been well tested,
> even though compliers warn about it ?

OK, I've reverted this to what it was before.

Marc.

+----------------------------------+-----------------------------------+
|  Marc Aurele La France           |  work:   1-780-492-9310           |
|  Computing and Network Services  |  fax:    1-780-492-1729           |
|  352 General Services Building   |  email:  [EMAIL PROTECTED]          |
|  University of Alberta           +-----------------------------------+
|  Edmonton, Alberta               |                                   |
|  T6G 2H1                         |     Standard disclaimers apply    |
|  CANADA                          |                                   |
+----------------------------------+-----------------------------------+
XFree86 Core Team member.  ATI driver and X server internals.

_______________________________________________
Xpert mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/xpert

Reply via email to