On 2011-07-29 Jonathan Nieder wrote: > +sh "$XZDIFF" "$preimage" "$samepostimage" >/dev/null
I missed this during the first round. It's not necessarily sh that ends up as @POSIX_SHELL@ into the scripts, so it's possible that this will use a different shell to run xzdiff than normal use of xzdiff would. Ancient pre-POSIX /bin/sh doesn't run xzdiff and other scripts correctly. That's why there's @POSIX_SHELL@ which gets replaced by configure. (The test suite doesn't rely on @POSIX_SHELL@ so the test scripts themselves still need to work with old shells.) Solaris 10 is an example with a problematic /bin/sh. However, there's a better sh in the PATH first. So maybe it isn't a problem in practice; I didn't test now. Even though the above might be a problem, I have committed the patches. Thank you. -- Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
