On 27.02.20 20:52, Lasse Collin wrote:
On 2020-02-27 Mario Emmenlauer wrote:
Awesome! I've just tested the CMakeLists with the latest official
release xz-5.2.4 and it works flawless so far.
Anyway, more feedback from CMake users is welcome. The liblzma part
should work on multiple operating systems; it's not Windows-only
anymore. See the comment in the beginning of CMakeLists.txt in xz.git.
It seems I did find an impediment, after all. I've back-ported the
CMakeLists.txt to xz-5.2.4 as described before. The only change required
was to remove two source files, src/liblzma/common/file_info.c and
src/liblzma/common/index_decoder.h.
The build works for me on CentOS 7, Ubuntu 18.04, and macOS 10.14 with
XCode 11.3. But on Windows with VS2017 latest and VS2019 latest, I have
problems with the processing of liblzma_w32res.rc. Below is the error
message from nmake, but it fails in a similar (not identical) way with
ninja build system.
I tried debugging this, but there was nothing obvious that I could see.
Since there are no major changes between xz-5.2.4 and current HEAD with
respect to liblzma_w32res.rc and common.rc, I'm slightly confused what
may go wrong. Does this ring a bell with anyone?
[...]
[ 98%] Building RC object
CMakeFiles/liblzma.dir/src/liblzma/liblzma_w32res.rc.res
C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe -DDLL_EXPORT -DHAVE_CHECK_CRC32 -DHAVE_CHECK_CRC64 -DHAVE_CHECK_SHA256 -DHAVE_DECODERS -DHAVE_DECODER_ARM
-DHAVE_DECODER_ARMTHUMB -DHAVE_DECODER_DELTA -DHAVE_DECODER_IA64 -DHAVE_DECODER_LZMA1 -DHAVE_DECODER_LZMA2 -DHAVE_DECODER_POWERPC -DHAVE_DECODER_SPARC
-DHAVE_DECODER_X86 -DHAVE_ENCODERS -DHAVE_ENCODER_ARM -DHAVE_ENCODER_ARMTHUMB -DHAVE_ENCODER_DELTA -DHAVE_ENCODER_IA64 -DHAVE_ENCODER_LZMA1 -DHAVE_ENCODER_LZMA2
-DHAVE_ENCODER_POWERPC -DHAVE_ENCODER_SPARC -DHAVE_ENCODER_X86 -DHAVE_IMMINTRIN_H -DHAVE_INTTYPES_H -DHAVE_MF_BT2 -DHAVE_MF_BT3 -DHAVE_MF_BT4 -DHAVE_MF_HC3
-DHAVE_MF_HC4 -DHAVE_STDBOOL_H -DHAVE_STDINT_H -DHAVE_VISIBILITY=1 -DHAVE__BOOL -DHAVE__MM_MOVEMASK_EPI8 -DHAVE___BUILTIN_ASSUME_ALIGNED -DMYTHREAD_VISTA
-DPACKAGE_BUGREPORT=\"lasse.col...@tukaani.org\" -DPACKAGE_NAME="\"XZ Utils\"" -DPACKAGE_URL=\"https://tukaani.org/xz/\"; -DTUKLIB_FAST_UNALIGNED_ACCESS
-DTUKLIB_SYMBOL_PREFIX=lzma_ -Dliblzma_EXPORTS -IC:\data\Debug\xz-5.2.4\src\liblzma\api -IC:\data\Debug\xz-5.2.4\src\liblzma\common
-IC:\data\Debug\xz-5.2.4\src\liblzma\check -IC:\data\Debug\xz-5.2.4\src\liblzma\lz -IC:\data\Debug\xz-5.2.4\src\liblzma\rangecoder
-IC:\data\Debug\xz-5.2.4\src\liblzma\lzma -IC:\data\Debug\xz-5.2.4\src\liblzma\delta -IC:\data\Debug\xz-5.2.4\src\liblzma\simple
-IC:\data\Debug\xz-5.2.4\src\common -DWIN32 -D_DEBUG /fo CMakeFiles\liblzma.dir\src\liblzma\liblzma_w32res.rc.res
C:\data\Debug\xz-5.2.4\src\liblzma\liblzma_w32res.rc
NMAKE : fatal error U1077: 'C:\PROGRA~2\WI3CF2~1\10\bin\100183~1.0\x64\rc.exe'
: return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\bin\HostX64\x64\nmake.exe"' : return code
'0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\bin\HostX64\x64\nmake.exe"' : return code
'0x2'
Stop.
All the best,
Mario Emmenlauer
