These patches fix several bugs and make some improvements to the
handling of query windows and notifications.
The first two patches in the series fix obvious bugs in the handling of
incoming private messages, while the third suppresses a log message
generated by tapping on the status bar notification.
Patch 4 enables notifications for private messages of any kind, not just
ones which have the user's nick in the message -- I think this makes
more sense than the current behavior.
Patch 5 delivers private messages where the sender is the user's nick to
the window corresponding to the target of the message, not the sender
(the user herself). AFAIK, this isn't a common behavior, but it's a
huge improvement when using Bitlbee through irssi-proxy, and I think the
behavior makes sense.
Patch 6 rewrites the notifications system to include features such as a
count of new messages in the notification icon and a list of
conversations with new messages in the notification text. I'm unhappy
with the string used ("New messages in: #foo (1), #bar(2) ..."), but I
can't think of a better one.
Tested on a Nexus S running 2.3.4. This series can be applied
independently of the other ones I sent (though the last patch won't
apply cleanly without the leaks series).
Steven Luo (6):
Actually deliver actions to existing private message windows
Ensure privmsg with mention of user's nick opens new query when
appropriate
Add FLAG_ACTIVITY_NEW_TASK to notification intents
Notify the user on receipt of all private messages, not just ones
with nick mentions
Do something sane for private messages where the sender is our nick
Overhaul notifications system
application/res/values/strings.xml | 2 +
application/src/org/jibble/pircbot/PircBot.java | 6 +-
.../org/yaaic/activity/ConversationActivity.java | 14 ++-
application/src/org/yaaic/irc/IRCConnection.java | 142 +++++++++++--------
application/src/org/yaaic/irc/IRCService.java | 154 +++++++++++++++++---
.../listener/ConversationSelectedListener.java | 14 ++-
application/src/org/yaaic/model/Conversation.java | 25 +++
application/src/org/yaaic/model/Server.java | 17 ++
8 files changed, 289 insertions(+), 85 deletions(-)
--
1.7.2.5
