Prologue: I am NOT contesting that you fixed things (please keep this in mind throught reading this message), but you stubbornly say that it didn't work before, which I think is not correct.
> In one sense you were right, it > already works (after a few simplifications here and there though, but it > is only few lines changes). What changes, except for fixing cos? > It needs a few more things in cell so that the renderer will display the > correct thing, but infinite shear works here at the moment (more > difficult to understand with a single diff as in previous one). It did work before as well... > Regarding the diff I sent you, there is nothing infinite with it. The > point was only to define aabb's correctly (it was wrong before for non > symmetric shear (not "pure"), as you use the same cos(angle) for two > different axis), and to avoid reseting refSize after cloud compression > (I mean, you can still reset, but you don't have to). > Appart from that, the only gain is you can "simple shear" a bit longer > before the aabb size limit. Are you sure your enlarge is correct? It must be mathematically equal to cos for in-plane shear, since that is derived geometrically. The fact that it is not correct can be seen, I think, already from the fact that it enlarges the same along all axes, so it either gratuitously overestimates or is wrong. The rendering code for Aabb is correct, I think, so you can use that + some extreme shear value to at least visually check. v _______________________________________________ Mailing list: https://launchpad.net/~yade-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~yade-dev More help : https://help.launchpad.net/ListHelp
