------------------------------------------------------------
revno: 4032
committer: bchareyre <bruno.chare...@grenoble-inp.fr>
timestamp: Thu 2017-04-13 13:56:42 +0200
message:
Minor changes in authorship and inline comments
modified:
pkg/common/ForceEngine.cpp
pkg/common/HydroForceEngine.cpp
pkg/common/InsertionSortCollider.cpp
--
lp:yade
https://code.launchpad.net/~yade-pkg/yade/git-trunk
Your team Yade developers is subscribed to branch lp:yade.
To unsubscribe from this branch go to
https://code.launchpad.net/~yade-pkg/yade/git-trunk/+edit-subscription
=== modified file 'pkg/common/ForceEngine.cpp'
--- pkg/common/ForceEngine.cpp 2017-04-05 17:18:06 +0000
+++ pkg/common/ForceEngine.cpp 2017-04-13 11:56:42 +0000
@@ -1,6 +1,5 @@
// 2004 © Janek Kozicki <cosu...@berlios.de>
// 2009 © Václav Šmilauer <eudo...@arcig.cz>
-// 2014 © Raphael Maurin <raphael.mau...@irstea.fr>
#include"ForceEngine.hpp"
#include<core/Scene.hpp>
=== modified file 'pkg/common/HydroForceEngine.cpp'
--- pkg/common/HydroForceEngine.cpp 2017-04-05 17:18:06 +0000
+++ pkg/common/HydroForceEngine.cpp 2017-04-13 11:56:42 +0000
@@ -1,5 +1,3 @@
-// 2004 © Janek Kozicki <cosu...@berlios.de>
-// 2009 © Václav Šmilauer <eudo...@arcig.cz>
// 2014 © Raphael Maurin <raphael.mau...@irstea.fr>
#include"HydroForceEngine.hpp"
=== modified file 'pkg/common/InsertionSortCollider.cpp'
--- pkg/common/InsertionSortCollider.cpp 2016-08-24 16:28:27 +0000
+++ pkg/common/InsertionSortCollider.cpp 2017-04-13 11:56:42 +0000
@@ -404,6 +404,9 @@
return (xNorm-floor(xNorm))*(x1-x0);
}
+//NOTE: possible improvements:
+// 1) (not only periodic) keep a mask defining overlaps in directions 1,2,3, and compare the sum instead of checking overlap in three directions everytime there is an inversion. (maybe not possible? does it need a N² table?!!)
+// 2) use norm() only when needed (first and last elements, mainly, can be treated as special cases)
void InsertionSortCollider::insertionSortPeri(VecBounds& v, InteractionContainer* interactions, Scene*, bool doCollide){
assert(periodic);
long &loIdx=v.loIdx; const long &size=v.size;
_______________________________________________
Mailing list: https://launchpad.net/~yade-dev
Post to : yade-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yade-dev
More help : https://help.launchpad.net/ListHelp
