Public bug reported: In some JS files, there are trailing commas able to break Horizon on old web browsers.
Example (in horizon/static/horizon/js/horizon.d3linechart.js, line 187): domain: function($super) { var ret = $super(); // If y axis wants to have static range, not based on data if (this.yMin !== undefined && this.yMax !== undefined){ ret.y = [this.yMin, this.yMax]; } return ret; }, <-- can cause an error " Expected identifier, string or number". }); ** Affects: horizon Importance: Undecided Assignee: Robert Mizielski (miziel-r) Status: New ** Changed in: horizon Assignee: (unassigned) => Robert Mizielski (miziel-r) ** Summary changed: - Unnecessary commas in JS files able to break Horizon on old web browsers. + Traling commas in JS files able to break Horizon on old web browsers. ** Description changed: - In some JS files, there are trailling commas able to break Horizon on - old web browsers. + In some JS files, there are trailing commas able to break Horizon on old + web browsers. Example (in horizon/static/horizon/js/horizon.d3linechart.js, line 187): - domain: function($super) { - var ret = $super(); - // If y axis wants to have static range, not based on data - if (this.yMin !== undefined && this.yMax !== undefined){ - ret.y = [this.yMin, this.yMax]; - } - return ret; - }, <-- can cause an error " Expected identifier, string or number". + domain: function($super) { + var ret = $super(); + // If y axis wants to have static range, not based on data + if (this.yMin !== undefined && this.yMax !== undefined){ + ret.y = [this.yMin, this.yMax]; + } + return ret; + }, <-- can cause an error " Expected identifier, string or number". }); -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1308952 Title: Traling commas in JS files able to break Horizon on old web browsers. Status in OpenStack Dashboard (Horizon): New Bug description: In some JS files, there are trailing commas able to break Horizon on old web browsers. Example (in horizon/static/horizon/js/horizon.d3linechart.js, line 187): domain: function($super) { var ret = $super(); // If y axis wants to have static range, not based on data if (this.yMin !== undefined && this.yMax !== undefined){ ret.y = [this.yMin, this.yMax]; } return ret; }, <-- can cause an error " Expected identifier, string or number". }); To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1308952/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp