Public bug reported:
There are a number of problems where the virt driver impls do not match the API
defined by the base ComputeDriver class.
For example
- Libvirt: Adds 'SOFT' as default value for 'reboot' method but no other
class does
- XenAPI: set_admin_passwd takes 2 parameters but base class defines it with 3
parameters in a different order
- VMWare: update_host_status method which doesn't exist in base class & is
never called in entire codebase
- All: names of parameters are not the same as names of parameters in the base
class
- ...more...
These inconsistencies are functional bugs in the worst, or misleading to
maintainers in the best case. It should be possible to write a test
using the python 'inspect' module which guarantees that the sub-class
APis actually match what they claim to implement from the base class.
** Affects: nova
Importance: Undecided
Assignee: Daniel Berrange (berrange)
Status: New
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1333219
Title:
Virt driver impls don't match ComputeDriver base class API
Status in OpenStack Compute (Nova):
New
Bug description:
There are a number of problems where the virt driver impls do not match the
API defined by the base ComputeDriver class.
For example
- Libvirt: Adds 'SOFT' as default value for 'reboot' method but no other
class does
- XenAPI: set_admin_passwd takes 2 parameters but base class defines it with
3 parameters in a different order
- VMWare: update_host_status method which doesn't exist in base class & is
never called in entire codebase
- All: names of parameters are not the same as names of parameters in the
base class
- ...more...
These inconsistencies are functional bugs in the worst, or misleading
to maintainers in the best case. It should be possible to write a test
using the python 'inspect' module which guarantees that the sub-class
APis actually match what they claim to implement from the base class.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1333219/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
