** Changed in: nova Status: Fix Committed => Fix Released ** Changed in: nova Milestone: None => kilo-2
-- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1370948 Title: ComputeCapabilitiesFilter doesn't provide enough information on failure Status in OpenStack Compute (Nova): Fix Released Bug description: ComputeCapabilitiesFilter code is convoluted. There are at least 4 different ways it can fail, and 3 of them don't provide any output at all. The one which does logs at debug (should be info), and does not actually provide enough info to diagnose the problem. The code around here https://github.com/openstack/nova/blob/master/nova/scheduler/filters/compute_capabilities_filter.py#L33 and below could do with a nice bit of TLC. For example: - the for loop on line #49 can only ever be iterating on range(0,1) which is "once", ie no need for a loop. - the redefinition of "cap" makes it difficult to reason about what data is being worked on. - the above-mentioned lack of logging. I recommend checking the strength of the unit tests also, to give confidence that a refactoring doesn't introduce any regressions. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1370948/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp