Reviewed: https://review.openstack.org/258891 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=700b7ef26db914a790b728ffded9db0aad3aab0f Submitter: Jenkins Branch: master
commit 700b7ef26db914a790b728ffded9db0aad3aab0f Author: Sabari Kumar Murugesan <smuruge...@vmware.com> Date: Thu Dec 17 00:25:38 2015 -0800 Fix re-adding deleted members to an image in v1 If you replace the membership list of an image with some members that were previously deleted, we fail to re-add those deleted members. This seems to be a consequence of a previous commit d6800e143ddff8898d693bbef65d2143544d7ad0 which failed to update the deleted records. Closes-Bug: 1527143 Change-Id: Ic3ca9b56712a99652e65cb0a4e3f1e0ba15b8593 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1527143 Title: Unable to re-add deleted members to an image in v1 Status in Glance: Fix Released Bug description: If you replace the membership list of an image with some members that were previously deleted, we fail to re-add those deleted members. This is observed with the replace membership list API i.e PUT request to http://localhost:9292/v1/images/<IMAGE_ID>/members Note:- Individually deleting & re-adding members to an image does work E.g 1. Add a new member to an image using the bulk update API (i.e replace membership list) :- curl -X PUT -H "X-Auth-Token: CHANGEME" -H "Content-Type: application/json" -d '{ "memberships": [ { "member_id": "test-member-12345", "can_share": false } ] }' 'http://localhost:9292/v1/images/<IMAGE_ID>/members' 2. glance --os-image-api-version 1 member-delete <IMAGE_ID> "test- member-12345" 3. Repeat step 1 (i.e add the same member again) 4. glance --os-image-api-version 1 member-list --image-id <IMAGE_ID> ACTUAL:- +----------+-----------+-----------+ | Image ID | Member ID | Can Share | +----------+-----------+-----------+ +----------+-----------+-----------+ EXPECTED:- +--------------------------------------+-------------------+-----------+ | Image ID | Member ID | Can Share | +--------------------------------------+-------------------+-----------+ | 7ae9ca4b-9f65-4549-8c36-304a06e76294 | test-member-12345 | | +--------------------------------------+-------------------+-----------+ This seems to be a consequence of the fix for bug https://bugs.launchpad.net/glance/+bug/1462315 To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1527143/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp