Reviewed: https://review.openstack.org/277606 Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=82cdb40f870c958da6ab6ef447b35be2eaec5c8d Submitter: Jenkins Branch: master
commit 82cdb40f870c958da6ab6ef447b35be2eaec5c8d Author: Jenkins <jenk...@review.openstack.org> Date: Thu Feb 11 17:22:19 2016 +0000 Lun id's > 255 should be converted to hex This patch addresses the issue where lun id's values are larger than 255 and are being kept as integers. This causes the volume and search paths to be malformed and volumes can't be found. This patch adds two functions to linuxscsi.py to process the lun id's; they can process both a single lun id and a list of them. If a lun id has a value larger than 255 it is converted to hex. This patch also modifies the necessary unit tests and adds ones to cover the new main function. Change-Id: Ib0b2f239a8152275de9ea66fa99a286dfbe53d57 Closes-bug: #1493350 ** Changed in: os-brick Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1493350 Title: Attach Volume fail : Cinder - ISCSI device symlinks under /dev/disk /by-path in hex. Status in Cinder: Confirmed Status in OpenStack Compute (nova): Opinion Status in os-brick: Fix Released Bug description: As part of POC for an enterprise storage we have implemented an ISCSIDriver. Volume operation works as expected. Facing an issue with attach volume. Request your help. 1. If the volume lun id in backend storage is less than 255 attach volume works fine. Symlinks in /dev/disk/by-path is as below lrwxrwxrwx 1 root root 9 Jun 18 15:18 ip-192.168.5.100:3260-iscsi-iqn.1989-10.jp.co.xyz:storage.ttsp.2ec7fdda.ff5c4a16.0-lun-169 -> ../../sde lrwxrwxrwx 1 root root 9 Aug 26 14:47 ip-192.168.5.100:3260-iscsi-iqn.1989-10.jp.co.xyz:storage.ttsp.2ec7fdda.ff5c4a16.0-lun-172 -> ../../sdi 2. If volume lun id is more than 255, /dev/disk/by-path is an hexadecimal number and hence attach volume is failing with message Volume path not found. Symlinks in /dev/disk/by-path is as below [hexadecimal lun id according to SCSI standard ( REPORT LUNS)] lrwxrwxrwx 1 root root 9 Aug 26 14:47 ip-192.168.5.100:3260-iscsi-iqn.1989-10.jp.co.xxx:storage.ttsp.2ec7fdda.ff5c4a16.0-lun-0x016b000000000000 -> ../../sdh lrwxrwxrwx 1 root root 9 Jun 18 15:18 ip-192.168.5.100:3260-iscsi-iqn.1989-10.jp.co.xxx:storage.ttsp.2ec7fdda.ff5c4a16.0-lun-0x0200000000000000 -> ../../sdc Please provide your suggession. I would suggest cinder utility to have a check of both with normal lun-id in /dev/disk/by-path as well as hexadecimal lunid. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1493350/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp