Reviewed: https://review.openstack.org/279383 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c28b8267de69d099c8a97f6bb5b796208c5575ca Submitter: Jenkins Branch: master
commit c28b8267de69d099c8a97f6bb5b796208c5575ca Author: Thai Tran <tqt...@us.ibm.com> Date: Wed Feb 17 11:01:42 2016 -0800 Using events to clear table selections instead of scope We currently use scope to clear table selections. This is not ideal because it breaks encapsulation and encourages the use of scope over ctrl. This patch adds a clear method and uses event propagation to invoke it. Change-Id: I6115047298d5fa673eabb707a358c84a4e6d9eb6 Closes-Bug: #1544835 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1544835 Title: Using scope to clear table selections Status in OpenStack Dashboard (Horizon): Fix Released Bug description: We currently use scope to clear table selections. This is not ideal because it breaks encapsulation and encourages the use of scope over ctrl. We should provide a method that can clear instead. Reference: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images.controller.js#L101 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1544835/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp