Reviewed: https://review.openstack.org/284301 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c28ad6b8e38884c6e1cc7504e478608349fc0376 Submitter: Jenkins Branch: master
commit c28ad6b8e38884c6e1cc7504e478608349fc0376 Author: Terry Wilson <twil...@redhat.com> Date: Tue Feb 23 06:16:13 2016 -0600 Fix sanity check --no* BoolOpts If --config-{file,dir} are used to genearate a list of tests to run, using set_override() will also override any options passed via the CLI. For example, on Centos 7 which uses dnsmasq 2.66, running: neutron-sanity-check --nodnsmasq_version --config-file \ /etc/neutron/l3_agent.ini will still run and fail the dnsmasq version test. Using set_default() allows using --config-{file,dir} and --no* in conjunction. Closes-Bug: #1549394 Change-Id: I5b9e520add7324660148c4451bbef54c0dfe428e ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1549394 Title: neutron-sanity-check --no* BoolOpts don't work Status in neutron: Fix Released Bug description: neutron-sanity-check allows the passing of --config-file and --config- dir to automatically set which tests are run based on neutron's configuration. Since the test options are BoolOpts, they automatically register --no* inverse options. This implies that one could pass --config-file /etc/neutron/l3_agent.ini and then disable the dnsmasq_version check with --nodnsmasq_version. neutron-sanity-check uses set_override() to override the test configuration, which also overrides the CLI. Using set_default() should fix the issue. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1549394/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp