Reviewed: https://review.openstack.org/265286
Committed:
https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=6f2963d75204acd515089b70496f2ca3d0397f60
Submitter: Jenkins
Branch: master
commit 6f2963d75204acd515089b70496f2ca3d0397f60
Author: Akihiro Motoki <mot...@da.jp.nec.com>
Date: Fri Jan 8 23:16:43 2016 +0900
refactor: Avoid overriding run() in cliff command
cliff Command subclasses are suggested to override take_action.
run() method is reserved for extending base classes.
Thus, this commit changes to implement take_action() instead of run().
Closes-Bug: #1532258
Change-Id: Id845a80dbad2f436df5a55c9be502068e6f7b291
** Changed in: python-neutronclient
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1532258
Title:
neutronclient commands do not follow cliff command guideline
Status in neutron:
Fix Released
Status in python-neutronclient:
Fix Released
Bug description:
The docstring of cliff.command.Command says that developers
implementing commands should override take_action instead of run [1].
neutornclient DeleteCommand and UpdateCommand override run().
take_action() should be used.
In addition, neutronclient.common.command.OpenStackCommand provides an
extra and meaningless layer and interface get_data(). get_data()
provides no addition value. take_action() should be used.
CreateCommand, ShowCommand and ListCommand are affected.
[1]
https://github.com/openstack/cliff/blob/master/cliff/command.py#L39-L52
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1532258/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
