Reviewed: https://review.openstack.org/287575 Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=75d85aab3c7e1c2879a385f3e6eb8f96e6ceeb60 Submitter: Jenkins Branch: master
commit 75d85aab3c7e1c2879a385f3e6eb8f96e6ceeb60 Author: Tin Lam <tl3...@att.com> Date: Wed Mar 2 21:19:24 2016 -0600 Moved CORS middleware configuration into oslo-config-generator The default values needed for manila's implementation of cors middleware have been moved from paste.ini into the configuration hooks provided by oslo.config. Furthermore, these values have been added to the default initialization procedure. This ensures that if a value remains unset in the configuration file, it will fallback to using sane defaults. It also ensures that an operator modifying the configuration will be presented with that same set of defaults. Change-Id: Ie4adc39866a4ee6132eab6a111660218b3e6e5bd Closes-Bug: #1551836 ** Changed in: manila Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1551836 Title: CORS middleware's latent configuration options need to change Status in Aodh: Fix Released Status in Barbican: In Progress Status in Ceilometer: Fix Released Status in Cinder: In Progress Status in cloudkitty: In Progress Status in congress: In Progress Status in Cue: In Progress Status in Designate: In Progress Status in Glance: Fix Released Status in heat: In Progress Status in Ironic: Fix Released Status in OpenStack Identity (keystone): Fix Released Status in Magnum: In Progress Status in Manila: Fix Released Status in Mistral: In Progress Status in Murano: Fix Released Status in neutron: In Progress Status in OpenStack Compute (nova): Fix Released Status in oslo.config: Fix Released Status in Sahara: Fix Released Status in OpenStack Search (Searchlight): In Progress Status in Solum: Fix Released Status in Trove: In Progress Bug description: It was pointed out in http://lists.openstack.org/pipermail/openstack- dev/2016-February/086746.html that configuration options included in paste.ini are less than optimal, because they impose an upgrade burden on both operators and engineers. The following discussion expanded to all projects (not just those using paste), and the following conclusion was reached: A) All generated configuration files should contain any headers which the API needs to operate. This is currently supported in oslo.config's generate-config script, as of 3.7.0 B) These same configuration headers should be set as defaults for the given API, using cfg.set_defaults. This permits an operator to simply activate a domain, and not have to worry about tweaking additional settings. C) All hardcoded headers should be detached from the CORS middleware. D) Configuration and activation of CORS should be consistent across all projects. It was also agreed that this is a blocking bug for mitaka. A reference patch has already been approved for keystone, available here: https://review.openstack.org/#/c/285308/ To manage notifications about this bug go to: https://bugs.launchpad.net/aodh/+bug/1551836/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp