Reviewed: https://review.openstack.org/295605
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=ff3232a318a249e2320f0a0fac9589e0ce7d4018
Submitter: Jenkins
Branch: master
commit ff3232a318a249e2320f0a0fac9589e0ce7d4018
Author: Justin Pomeroy <jpom...@linux.vnet.ibm.com>
Date: Mon Mar 21 14:31:07 2016 -0500
Disable all actions while performing action
This updates the angular actions controller so that all actions
controlled by the same actions controller become disabled immediately
when performing any action. This prevents the user from being able to
click an action a second time while the action is being initialized.
This is mainly a problem in cases where there is some asynchronous
operation happening that needs to resolve before the action can be
performed. For example, the Update Metadata action needs two API
calls to resolve before the modal is displayed. If the requests take
a long time to resolve or the user is feeling anxious they can click
the action a second time, or even some other action before the Update
Metadata modal even gets displayed.
This is not a perfect fix since there are a number of other bad
things a user could do if an action takes a long time such as
clicking a link or breadcrumb to navigate to another page. Ideally
actions should result in immediate feedback to the user and any
asynchronous operations happen afterwards. For example, the metadata
modal gets displayed immediately with a loading indicator and then
the API requests are initiated.
Closes-Bug: #1560303
Change-Id: I7d7696a03de85434f692ab0313d3dbdcbb582f25
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1560303
Title:
Angular actions do not prevent multiple clicks
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
The angular actions list widget does not prevent the user from being
able to click an action multiple times before it has been performed.
This is mainly a problem when the action results in some asynchronous
operation that must resolve before the action can actually be
performed. Specifically the Update Metadata action on the angular
images table is a good example of this. After clicking the action,
there are two API requests that need to resolve before the user sees
the metadata modal. If those requests take a long time it's easy to
click the action multiple times and get more than one modal.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1560303/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
