Reviewed: https://review.openstack.org/292640 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c3db0707eff70f381913643891ba4e148977407d Submitter: Jenkins Branch: master
commit c3db0707eff70f381913643891ba4e148977407d Author: Jamie Lennox <jamielen...@gmail.com> Date: Tue Mar 15 10:05:29 2016 +1100 Return oslo_config Opts to config generator We shouldn't be returning keystoneauth Opts to the oslo_config generator. Whilst it mostly works these objects are not interchangable and it can result in problems. You can see this by entries such as: # Warning: Failed to format sample for tenant_name # isinstance() arg 2 must be a class, type, or tuple of classes and types in the currently generated config files. Keystoneauth provides a function that returns oslo_config options so fetch, process and return those instead. Change-Id: Ie3fad2381467b19189cbb332c41cea8b6cf6e264 Closes-Bug: #1548433 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1548433 Title: neutron returns objects other than oslo_config.cfg.Opt instances from list_opts Status in keystoneauth: Incomplete Status in neutron: Fix Released Status in OpenStack Compute (nova): Fix Released Bug description: The neutron function for listing options for use with the configuration generator returns things that are not compliant with the oslo_config.cfg.Opt class API. At the very least this includes the options from keystoneauth1, but I haven't looked to find if there are others. We'll work around this for now in the configuration generator code, but in the future we will more strictly enforce the API compliance by refusing to generate a configuration file or by leaving options out of the output. The change blocked by this issue is: https://review.openstack.org/#/c/282435/5 One failure log showing the issue is: http://logs.openstack.org/35/282435/5/check/gate-tempest-dsvm-neutron- src-oslo.config/77044c6/logs/devstacklog.txt.gz The neutron code triggering the issue is in: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/opts.py#n279 The best solution would be to fix keystoneauth to support option discovery natively using proper oslo.config Opts. To manage notifications about this bug go to: https://bugs.launchpad.net/keystoneauth/+bug/1548433/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp