Reviewed: https://review.openstack.org/314112 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d526e720f73cbd79e54bbed18fe3009cad1cee10 Submitter: Jenkins Branch: master
commit d526e720f73cbd79e54bbed18fe3009cad1cee10 Author: Sreekumar S <sree...@gmail.com> Date: Mon May 9 19:17:27 2016 +0530 Fix for 'ofport' query retries during neutron agent start When agent starts up, it checks whether patch ports exists before adding them. But the routine used to query the patch port's existence is get_port_ofport() which retries the opertation because of the @_ofport_retry decoration. This creates an unwanted delay in the startup of the agent, when the port do not exist. The port's existence can be checked with port_exists() call on the bridge with no retries. Change-Id: I9fac0066d6c03491536a6e2718d6340acd275d9d Closes-Bug: #1579769 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1579769 Title: neutron agent restart slow when bridge ports are missing Status in neutron: Fix Released Bug description: When bridge ports are missing for br-int and br-tun and agent starts up, it checks for patch ports int-br-ex and phy-br-ex before adding those. But here the function used to check their existence is get_port_ofport() which retries it because of the @_ofport_retry decoration. This causes the restart to become unnecessarily slow because of the retries. get_port_ofport() should be used only when the port is requested to be created, and the code waits for the ports to be created before proceeding further. We could've just checked for the port's existence with a call to port_exists() on the bridge. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1579769/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp