Reviewed: https://review.openstack.org/313277
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=483c5982c020ff21ceecf1d575c2d8fad2937d6e
Submitter: Jenkins
Branch: master
commit 483c5982c020ff21ceecf1d575c2d8fad2937d6e
Author: Dmitriy Ukhlov <dukh...@mirantis.com>
Date: Fri May 6 08:41:07 2016 +0000
Revert "Revert "Remove threading before process forking""
This reverts commit b1cdba1696f5d4ec71d37a773501bd4f9e0cddb9
Original patch was reverted because it broke neutron plugin's
backward compatibility and needed more work.
This patch fixes that problems:
1) original behaviour of add_agent_status_check,
start_periodic_l3_agent_status_check and
start_periodic_dhcp_agent_status_check methods is deprecated but kept
for using in third part plugins for backward compatibility
2) new add_agent_status_check_worker, add_periodic_l3_agent_status_check
and add_periodic_dhcp_agent_status_check method are implemented
instead and are used for implementing plugins in neutron codebase
Closes-Bug: #1569404
Change-Id: I3a32a95489831f0d862930384309eefdc881d8f6
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1569404
Title:
Remove threading before process forking
Status in neutron:
Fix Released
Bug description:
Forking processes when a few threads are already running is
potentially unsafe operation and could cause a lot of problems because
only current thread will continue working in child thread. Any locked
by other thread resource will remain locked forever.
We faced with this problem during oslo.messaging development and added
workaround to hide this problem:
https://review.openstack.org/#/c/274255/ I tried to fix this problem
in oslo.service: https://review.openstack.org/#/c/270832/ but oslo
folks said that this fix is ugly and it is wrong way to add
workarounds to common libraries because projects use them incorrectly.
I think that is fare.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1569404/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
