Reviewed: https://review.openstack.org/340933 Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=2d7b864b1715f0569e37e3be55d6c6b0461c5cd5 Submitter: Jenkins Branch: master
commit 2d7b864b1715f0569e37e3be55d6c6b0461c5cd5 Author: haobing1 <hao.bi...@zte.com.cn> Date: Tue Jul 12 21:11:05 2016 +0800 Fix string interpolation to delayed to be handled by the logging code String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. See the oslo i18n guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html Change-Id: If06663076e4081c6268ba88c157513723b734b31 Closes-Bug: #1596829 ** Changed in: python-glanceclient Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1596829 Title: String interpolation should be delayed at logging calls Status in Ceilometer: New Status in Glance: In Progress Status in glance_store: New Status in heat: New Status in Ironic: Fix Released Status in OpenStack Identity (keystone): New Status in networking-vsphere: Fix Released Status in neutron: Fix Released Status in OpenStack Compute (nova): In Progress Status in os-brick: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: Fix Released Status in python-neutronclient: Fix Released Status in OpenStack Object Storage (swift): New Status in taskflow: New Bug description: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Wrong: LOG.debug('Example: %s' % 'bad') Right: LOG.debug('Example: %s', 'good') See the following guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html #adding-variables-to-log-messages The rule for it should be added to hacking checks. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp