Reviewed: https://review.openstack.org/343026
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=2e23ed32978697400a2b3d324f0878f3539836c3
Submitter: Jenkins
Branch: master
commit 2e23ed32978697400a2b3d324f0878f3539836c3
Author: Aliaksandr Dziarkach <adziark...@infoblox.com>
Date: Fri Jul 15 21:00:18 2016 +0300
fix port address allocation for auto-addr subnet
AutomaticAddressRequest is created manually in
add_auto_addr_on_network_ports.
But expected workkflow is to use address request factory, that can be
overriden by ipam driver to deliver custom AddressRequest classes.
Added code to follow expected workflow.
Now factory method called for SLAAC allocations, so third party ipam
driver can deliver custom AddressRequest for these allocations.
Change-Id: I95d6097a6bc30107e2819c484e9718f6a5ee619e
Closes-Bug: 1570465
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1570465
Title:
[Pluggable IPAM] AutomaticAddressRequest is created manually instead
of using factory
Status in neutron:
Fix Released
Bug description:
AutomaticAddressRequest is created manually in
add_auto_addrs_on_network_ports [1]. But expcected workflow is to use address
request factory, that can be overriden by ipam driver to deliver custom
AddressRequest classes.
Address request factory generates ip request based on input.
Expected way of preparing address request can be seen in [2]:
factory = ipam_driver.get_address_request_factory()
ip_request = factory.get_request(context, port, ip_dict)
Factory method is currently not called for SLAAC allocations, so third
party ipam driver can not deliver custom AddressRequest for this kind
of allocations.
[1]
https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L372
[2]
https://github.com/openstack/neutron/blob/2a305c563073a3066aac3f07aab3c895ec2cd2fb/neutron/db/ipam_pluggable_backend.py#L80
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1570465/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
