Reviewed: https://review.openstack.org/341905
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=304bc201c004d549de408c75cfe731eb65fde78d
Submitter: Jenkins
Branch: master
commit 304bc201c004d549de408c75cfe731eb65fde78d
Author: Adam Young <ayo...@redhat.com>
Date: Mon Sep 12 21:39:45 2016 -0400
Use to_policy_values for policy credentials
The base oslo.context defines to_policy_values with all the information
that it expects a service to require to enforce policy. Use that instead
of throwing everything in to_dict at policy enforcement.
Change-Id: I0a42b4425e9dd1bd062c48792c4d116dd370afe3
Closes-Bug: #1602081
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1602081
Title:
Use oslo.context's policy dict
Status in Cinder:
Fix Released
Status in Glance:
Fix Released
Status in heat:
Fix Released
Status in OpenStack Identity (keystone):
New
Status in neutron:
In Progress
Status in OpenStack Compute (nova):
Fix Released
Bug description:
This is a cross project goal to standardize the values available to
policy writers and to improve the basic oslo.context object. It is
part of the follow up work to bug #1577996 and bug #968696.
There has been an ongoing problem for how we define the 'admin' role.
Because tokens are project scoped having the 'admin' role on any
project granted you the 'admin' role on all of OpenStack. As a
solution to this keystone defined an is_admin_project field so that
keystone defines a single project that your token must be scoped to to
perform admin operations. This has been implemented.
The next phase of this is to make all the projects understand the X
-Is-Admin-Project header from keystonemiddleware and pass it to
oslo_policy. However this pattern of keystone changes something and
then goes to every project to fix it has been repeated a number of
times now and we would like to make it much more automatic.
Ongoing work has enhanced the base oslo.context object to include both
the load_from_environ and to_policy_values methods. The
load_from_environ classmethod takes an environment dict with all the
standard auth_token and oslo middleware headers and loads them into
their standard place on the context object.
The to_policy_values() then creates a standard credentials dictionary
with all the information that should be required to enforce policy
from the context. The combination of these two methods means in future
when authentication information needs to be passed to policy it can be
handled entirely by oslo.context and does not require changes in each
individual service.
Note that in future a similar pattern will hopefully be employed to
simplify passing authentication information over RPC to solve the
timeout issues. This is a prerequisite for that work.
There are a few common problems in services that are required to make
this work:
1. Most service context.__init__ functions take and discard **kwargs.
This is so if the context.from_dict receives arguments it doesn't know
how to handle (possibly because new things have been added to the base
to_dict) it ignores them. Unfortunately to make the load_from_environ
method work we need to pass parameters to __init__ that are handled by
the base class.
To make this work we simply have to do a better job of using
from_dict. Instead of passing everything to __init__ and ignoring what
we don't know we have from_dict extract only the parameters that
context knows how to use and call __init__ with those.
2. The parameters passed to the base context.__init__ are old.
Typically they are user and tenant where most services expect user_id
and project_id. There is ongoing work to improve this in oslo.context
but for now we have to ensure that the subclass correctly sets and
uses the right variable names.
3. Some services provide additional information to the policy
enforcement method. To continue to make this function we will simply
override the to_policy_values method in the subclasses.
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1602081/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
