Reviewed: https://review.openstack.org/384469
Committed:
https://git.openstack.org/cgit/openstack/horizon/commit/?id=1d13a052468ef1b66d1c75f98f52cc356ba81365
Submitter: Jenkins
Branch: master
commit 1d13a052468ef1b66d1c75f98f52cc356ba81365
Author: Paul Karikh <pkar...@mirantis.com>
Date: Mon Oct 10 15:20:36 2016 +0300
Remove hardcode of container_name in backups
If user doesn't set container name
for volume backup, Horizon sets default
value 'volumebackups'. If Cinder is configured
with different default value, this behaviour
will cause an error.
Since Cinder is able to handle case when
container name for backup is not set,
we should remove this hardcode from Horizon.
Change-Id: Ib121ac1d38f11e967ef059de57a8198c5e890198
Closes-Bug: #1631930
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1631930
Title:
Horizon default container name 'volumebackups' for volume backups
could be invalid
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Currently Horizon uses 'volumebackups' name as a default name for
container if user ignored thid field in CreateBackup form:
https://github.com/openstack/horizon/blob/stable/newton/openstack_dashboard/dashboards/project/volumes/backups/forms.py#L46
And in some cases `volumebackups` could be wrong name. For example, if
Ceph is used as a backend:
https://github.com/openstack/cinder/blob/b67d13ef4b9ac7d0bba92250ac5a77c15d8e9e68/cinder/backup/drivers/ceph.py#L84
If Horizon passes wrong default value, Cinder will fail creation of
backup with an error like this: `oslo_messaging.rpc.dispatcher
ObjectNotFound: error opening pool 'volumebackups'`
And since Cinder is able to fill missing value with correct default
name it is better to remove this Hardcode from Horizon side.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1631930/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
