Reviewed: https://review.openstack.org/422234 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=38bce1d869264a6f1ea0e13a0301c8cc4bfc84af Submitter: Jenkins Branch: master
commit 38bce1d869264a6f1ea0e13a0301c8cc4bfc84af Author: David Stanek <dsta...@dstanek.com> Date: Fri Mar 24 15:12:27 2017 +0000 Small fixes for WebOb 1.7 compatibiltity WebOb 1.7 includes a few changes that are not backward compatible. The ones I noticed and fixed are: 1. When supplying unicode content for the response body the charset is now required if headers are also provided. Previously a default was used. 2. Content-Length is no longer being set when creating a webob.Response object. It appears to be correctly set when directly setting the body property. Upstream change that caused the issues: https://github.com/Pylons/webob/commit/35fd585 Closes-bug: #1657452 Change-Id: Iaf2dd45fc86e3eb5e56be0a3e1582a6ddf960bc1 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1657452 Title: Incompatibility with python-webob 1.7.0 Status in Glance: Confirmed Status in OpenStack Identity (keystone): Fix Released Status in OpenStack Compute (nova): Confirmed Status in oslo.middleware: Confirmed Status in glance package in Ubuntu: Triaged Status in keystone package in Ubuntu: Triaged Status in nova package in Ubuntu: Triaged Status in python-oslo.middleware package in Ubuntu: Triaged Bug description: keystone.tests.unit.test_v3_federation.WebSSOTests.test_identity_provider_specific_federated_authentication ----------------------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "keystone/tests/unit/test_v3_federation.py", line 4067, in test_identity_provider_specific_federated_authentication self.PROTOCOL) File "keystone/federation/controllers.py", line 345, in federated_idp_specific_sso_auth return self.render_html_response(host, token_id) File "keystone/federation/controllers.py", line 357, in render_html_response headerlist=headers) File "/usr/lib/python2.7/dist-packages/webob/response.py", line 310, in __init__ "You cannot set the body to a text value without a " TypeError: You cannot set the body to a text value without a charset To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1657452/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp