Reviewed: https://review.openstack.org/450938 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a1683df77f8b71de938b7aef577d05d883667ccd Submitter: Jenkins Branch: master
commit a1683df77f8b71de938b7aef577d05d883667ccd Author: Anthony Washington <anthony.washing...@intel.com> Date: Tue Mar 28 19:17:07 2017 +0000 Remove unnecessary processing when deleting grant. When deleting a grant with an invalid role ID the exception RoleNotFound will be thrown. However, before that exception is thrown a lot of unnecessary work is being done. In order to improve that process, this patch checks that the role exists before continuing to delete a grant. Change-Id: I4f8a26a71096c7dd456195751562cba26c9853d7 Closes-Bug: 1406776 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Identity (keystone). https://bugs.launchpad.net/bugs/1406776 Title: Trying to delete a grant with an invalid role ID causes unnecessary processing Status in OpenStack Identity (keystone): Fix Released Bug description: Trying to delete a grant with an invalid role ID will throw a RoleNotFound exception. However, the check for this is buried in the driver...after the time the assignment manager has already carried out a bunch of processing (e.g. send out revokes). Is this by design (e.g. let people clear up tokens for a role ID that somehow has been already deleted) or just an error? Given that some processing for the revoking tokens also happens AFTER the driver call to delete the grant (which would abort on RoleNotFound), I'm kind of guessing the later. Views? To manage notifications about this bug go to: https://bugs.launchpad.net/keystone/+bug/1406776/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp