Reviewed: https://review.openstack.org/459420 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=620e630a696f68dba2d05fccd40a6569a6aff3d1 Submitter: Jenkins Branch: master
commit 620e630a696f68dba2d05fccd40a6569a6aff3d1 Author: Matt Riedemann <mriedem...@gmail.com> Date: Mon Apr 24 14:13:16 2017 -0400 libvirt: remove redundant and broken iscsi volume test This same test has existed in os-brick for a long time: I092a56e52bcea6adb6cb018cd059e6126a1dc07d And since _get_target_portals_from_iscsiadm_output has been changed in os-brick master to return a tuple instead of a list, this test is actually blocking us from being able to use os-brick 1.12.0. This change just removes it since it's no longer needed in nova. Change-Id: I82c31cc3b2ea3869ec37ff6add53abaec7a8591e Closes-Bug: #1672670 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1672670 Title: Unit tests fail with current os-brick master Status in OpenStack Compute (nova): Fix Released Status in os-brick: Invalid Bug description: When running Nova unit tests using the current os-brick from master, nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing fails . How to reproduce: 1- setup virtualenv with Nova test-requirements 2- pip install --upgrade git+https://github.com/openstack/os-brick 3- ostestr -r nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing Got the following traceback: nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing -------------------------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "nova/tests/unit/virt/libvirt/volume/test_iscsi.py", line 47, in test_iscsiadm_discover_parsing self.assertEqual(targets, out) File "/tmp/venv/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual self.assertThat(observed, matcher, message) File "/tmp/venv/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat raise mismatch_error testtools.matchers._impl.MismatchError: !=: reference = [['192.168.204.82:3260,1', 'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd3'], ['192.168.204.82:3261,1', 'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd4']] actual = (['192.168.204.82:3260,1', '192.168.204.82:3261,1'], ['iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd3', 'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd4']) https://review.openstack.org/433104 looks like the most probable cause. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1672670/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp