Reviewed: https://review.openstack.org/460551 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=49c6cdca927f2f262ba54b22f19713a65ae42563 Submitter: Jenkins Branch: master
commit 49c6cdca927f2f262ba54b22f19713a65ae42563 Author: Akihiro Motoki <amot...@gmail.com> Date: Thu Apr 27 13:10:54 2017 +0000 Use publicURL as default of OPENSTACK_ENDPOINT_TYPE consistently The current default settings of openstack_dashboard OPENSTACK_ENDPOINT_TYPE has two default values 'publicURL' and 'internalURL' and this leads to require both endpoints in deployments. Having two default values for one setting is confusing. The comment in local_settings.py says OPENSTACK_ENDPOINT_TYPE defaults to publicURL and operators does not think internalURL is used. I believe there is no negative side because if operators want to deploy horizon out side of their OpenStack clouds they use publicURL and if they want to deploy horizon behind load balancer or something they would use internalURL as OPENSTACK_ENDPOINT_TYPE. This also help the current devstack setup which only configures public endpoint (interface) and Horizon does not work by default for Identity dashboard. Closes-Bug: #1686717 Change-Id: If5c7bbc5188f6df65661c41d777a9c7846fe9008 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1686717 Title: Default value of OPENSTACK_ENDPOINT_TYPE is inconsistent Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The default value of OPENSTACK_ENDPOINT_TYPE has two values: - publicURL in openstack_dashboard/api/base.py - internalURL in openstack_dashboard/api/keystone.py One setting value should have one default value. Otherwise operators are sometimes confused. local/local_settings.py says: # OPENSTACK_ENDPOINT_TYPE specifies the endpoint type to use for the endpoints # in the Keystone service catalog. Use this setting when Horizon is running # external to the OpenStack environment. The default is 'publicURL'. In addition, the recent **devstack** only configures 'public' interface (endpoint type) and does not configure 'internal' interface. As a result, the current default configuration prevents a member role user to open 'Projects' panel. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1686717/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp