Reviewed: https://review.openstack.org/476736 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a50d21662e121c50457f3154200845450e2af301 Submitter: Jenkins Branch: master
commit a50d21662e121c50457f3154200845450e2af301
Author: Takashi NATSUME <natsume.taka...@lab.ntt.co.jp>
Date: Fri Jun 23 09:39:56 2017 +0900
Fix misuse of assertIsNone
Change-Id: If86f954a37c6c9e5d637db9f7d8d80e40d3b0fc9
Closes-Bug: #1699927
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1699927
Title:
Misuse of assertIsNone in tests
Status in OpenStack Compute (nova):
Fix Released
Bug description:
There are some misuse of assertIsNone.
self.assertIsNone(None, XXXX)
This check always passed, so it is useless.
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/unit/conductor/test_conductor.py#L1484
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/unit/virt/libvirt/test_migration.py#L47
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/functional/wsgi/test_servers.py#L74
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/functional/wsgi/test_servers.py#L75
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/functional/wsgi/test_servers.py#L104
https://github.com/openstack/nova/blob/6386692b4b01337569eab4cd6c2f0219d0fe1e74/nova/tests/functional/wsgi/test_servers.py#L105
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1699927/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
