Reviewed: https://review.openstack.org/505613 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ee7858ffcaf3f874feb0ea0c68871f2c93254fdd Submitter: Zuul Branch: master
commit ee7858ffcaf3f874feb0ea0c68871f2c93254fdd Author: Moshe Levi <mosh...@mellanox.com> Date: Wed Sep 20 15:24:29 2017 +0300 Don't overwrite binding-profile Currently when providing existing direct port, nova-compute will overwrite the binding-profile information with pci_vendor_info and pci_slot. The binding-profile will be used to request NIC capabilities for SR-IOV ports [1]. This also allows to distinguish which neutron mechanism driver will bind the port [2]. This patch updates the behaviour that on update port it will update, rather than overwrite, the binding-profile information with pci_vendor_info and pci_slot. And on unbind port it will remove only the pci_vendor_info and pci_slot from the port binding-profile rather than unsetting the entire field. [1] https://review.openstack.org/#/c/435954/ [2] https://review.openstack.org/#/c/499203/ Closes-Bug: #1719327 Change-Id: I80106707a037d567d0f690570f2cf9cfcd30d594 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1719327 Title: nova compute overwrite binding-profile when updating port direct port Status in OpenStack Compute (nova): Fix Released Bug description: in case a user create direct port with binding-profile such as: --binding-profile '{"capabilities": ["switchdev"]}'. nova-compute will overwrite that info with the pci_vendor_info pci_slot which are used for the SR-IOV mechanism driver and agent, and on delete it will clear the binding:profile. This change is important to OVS hardware-offload, because we distinguish between legacy SR-IOV to switchdev SR-IOV with the {"capabilities": ["switchdev"]} in the port profile. And with this info we know what mechanism driver will bind the direct port. {"capabilities": ["switchdev"]} - will bound by the OVS and all the others will be bound by SR-IOV mechanism driver To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1719327/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp