Reviewed: https://review.openstack.org/511074
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=9ef56fa86639f97f63d853dbb2213415dcd5691b
Submitter: Zuul
Branch: master
commit 9ef56fa86639f97f63d853dbb2213415dcd5691b
Author: Hongbin Lu <hongbin...@gmail.com>
Date: Tue Oct 10 23:05:14 2017 +0000
Handle not found error on taking snapshot
If there is a request to create a snapshot of an instance and
another request to delete the instance at the same time, the
snapshot task might fail with libvirt error and this error
is not handled correctly by compute manager. As a result,
tracestack was printed in the compute log.
This patch fixes it by handling libvirt exception during live
snapshot and raise instance not found exception if the libvirt
exception is raised due to domain not found.
Change-Id: I585b7b03753ed1d28a313ce443e6918687d76a8b
Closes-Bug: #1722571
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1722571
Title:
NotImplementedError(_('direct_snapshot() is not implemented'))
stacktraces in n-cpu logs
Status in OpenStack Compute (nova):
Fix Released
Bug description:
After we enabled live snapshot by default for the libvirt driver, we
get these stacktraces all over the n-cpu logs anytime we create a
snapshot image:
http://logs.openstack.org/65/509465/18/check/gate-tempest-dsvm-py35
-ubuntu-xenial/0e88c0a/logs/screen-n-cpu.txt#_Oct_10_13_48_24_125578
Oct 10 13:48:24.125578 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] Traceback (most recent call last):
Oct 10 13:48:24.125728 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] File
"/opt/stack/new/nova/nova/virt/libvirt/driver.py", line 1697, in snapshot
Oct 10 13:48:24.125890 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] instance.image_ref)
Oct 10 13:48:24.126025 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] File
"/opt/stack/new/nova/nova/virt/libvirt/imagebackend.py", line 412, in
direct_snapshot
Oct 10 13:48:24.126158 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] raise
NotImplementedError(_('direct_snapshot() is not implemented'))
Oct 10 13:48:24.126326 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf] NotImplementedError: direct_snapshot() is
not implemented
Oct 10 13:48:24.126485 ubuntu-xenial-infracloud-chocolate-11309928
nova-compute[26979]: ERROR nova.compute.manager [instance:
8cd13eb3-54cc-4ca3-9bfc-689efd768baf]
We shouldn't be stacktracing on that NotImplementedError since it's an
image backend-specific method implementation for handling snapshots,
and only the Rbd image backend implements direct_snapshot().
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1722571/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
