Reviewed: https://review.openstack.org/552789 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f494c6f2d475bfc936b78fda7ce11ed4d46c7224 Submitter: Zuul Branch: master
commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224 Author: Shu Muto <shu.mu...@gmail.com> Date: Wed Mar 14 11:43:12 2018 +0900 Fix Angular errors in openstack_auth Angular errors on login page are caused by loading ngdetails view. Although registration of URL for ngdetails is executed on top level of Horizon, ngdetails view is not needed to be loaded in login page, i.e. openstack_auth side. To fix this issue, this patch moves registration of URL for ngdetails into openstack_dashboard side. Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c Closes-Bug: #1754133 Closes-Bug: #1753557 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1754133 Title: login page exception - hz-login-finder doesn't function because of horizon.app loading failure Status in OpenStack Dashboard (Horizon): Fix Released Bug description: It happens to master and stable/pike. Didn't check other version. When access login page of horizon in Chrome, F12 you will see the following exceptions in the console. If it uses default keystone credential, it doesn't hurt, once login the exceptions are gone. However, if want to use the WEBSSO feature when angular invokes the hz-login-finder directive to hide the username/password inputs...it doesn't function. Looks like it is caused by the loading problem of horizon.app module Exceptions ---- Uncaught SyntaxError: Unexpected token < c575dddbc1e4.js:325 Uncaught ReferenceError: gettext is not defined at c575dddbc1e4.js:325 at c575dddbc1e4.js:325 (anonymous) @ c575dddbc1e4.js:325 (anonymous) @ c575dddbc1e4.js:325 732ce617825a.js:699 Uncaught Error: [$injector:nomod] Module 'horizon.app' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. http://errors.angularjs.org/1.5.8/$injector/nomod?p0=horizon.app at 732ce617825a.js:699 at 732ce617825a.js:818 at ensure (732ce617825a.js:816) at Object.module (732ce617825a.js:818) at 680be8487836.js:1 (anonymous) @ 732ce617825a.js:699 (anonymous) @ 732ce617825a.js:818 ensure @ 732ce617825a.js:816 module @ 732ce617825a.js:818 (anonymous) @ 680be8487836.js:1 732ce617825a.js:699 Uncaught Error: [$injector:modulerr] Failed to instantiate module horizon.app due to: Error: [$injector:nomod] Module 'horizon.app' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. http://errors.angularjs.org/1.5.8/$injector/nomod?p0=horizon.app at https://myhelion.test/static/dashboard/js/732ce617825a.js:699:8 at https://myhelion.test/static/dashboard/js/732ce617825a.js:818:59 at ensure (https://myhelion.test/static/dashboard/js/732ce617825a.js:816:320) at module (https://myhelion.test/static/dashboard/js/732ce617825a.js:818:8) at https://myhelion.test/static/dashboard/js/732ce617825a.js:925:35 at forEach (https://myhelion.test/static/dashboard/js/732ce617825a.js:703:400) at loadModules (https://myhelion.test/static/dashboard/js/732ce617825a.js:924:156) at createInjector (https://myhelion.test/static/dashboard/js/732ce617825a.js:913:464) at doBootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:792:36) at bootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:793:58) http://errors.angularjs.org/1.5.8/$injector/modulerr?p0=horizon.app&p1=Error%3A%20%5B%24injector%3Anomod%5D%20Module%20'horizon.app'%20is%20not%20available!%20You%20either%20misspelled%20the%20module%20name%20or%20forgot%20to%20load%20it.%20If%20registering%20a%20module%20ensure%20that%20you%20specify%20the%20dependencies%20as%20the%20second%20argument.%0Ahttp%3A%2F%2Ferrors.angularjs.org%2F1.5.8%2F%24injector%2Fnomod%3Fp0%3Dhorizon.app%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A699%3A8%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A818%3A59%0A%20%20%20%20at%20ensure%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A816%3A320)%0A%20%20%20%20at%20module%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A818%3A8)%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A925%3A35%0A%20%20%20%20at%20forEach%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A703%3A400)%0A%20%20%20%20at%20loadModules%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A924%3A156)%0A%20%20%20%20at%20createInjector%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A913%3A464)%0A%20%20%20%20at%20doBootstrap%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A792%3A36)%0A%20%20%20%20at%20bootstrap%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A793%3A58) at https://myhelion.test/static/dashboard/js/732ce617825a.js:699:8 at https://myhelion.test/static/dashboard/js/732ce617825a.js:818:59 at ensure (https://myhelion.test/static/dashboard/js/732ce617825a.js:816:320) at module (https://myhelion.test/static/dashboard/js/732ce617825a.js:818:8) at https://myhelion.test/static/dashboard/js/732ce617825a.js:925:35 at forEach (https://myhelion.test/static/dashboard/js/732ce617825a.js:703:400) at loadModules (https://myhelion.test/static/dashboard/js/732ce617825a.js:924:156) at createInjector (https://myhelion.test/static/dashboard/js/732ce617825a.js:913:464) at doBootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:792:36) at bootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:793:58) http://errors.angularjs.org/1.5.8/$injector/modulerr?p0=horizon.app&p1=Error%3A%20%5B%24injector%3Anomod%5D%20Module%20'horizon.app'%20is%20not%20available!%20You%20either%20misspelled%20the%20module%20name%20or%20forgot%20to%20load%20it.%20If%20registering%20a%20module%20ensure%20that%20you%20specify%20the%20dependencies%20as%20the%20second%20argument.%0Ahttp%3A%2F%2Ferrors.angularjs.org%2F1.5.8%2F%24injector%2Fnomod%3Fp0%3Dhorizon.app%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A699%3A8%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A818%3A59%0A%20%20%20%20at%20ensure%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A816%3A320)%0A%20%20%20%20at%20module%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A818%3A8)%0A%20%20%20%20at%20https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A925%3A35%0A%20%20%20%20at%20forEach%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A703%3A400)%0A%20%20%20%20at%20loadModules%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A924%3A156)%0A%20%20%20%20at%20createInjector%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A913%3A464)%0A%20%20%20%20at%20doBootstrap%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A792%3A36)%0A%20%20%20%20at%20bootstrap%20(https%3A%2F%2Fmyhelion.test%2Fstatic%2Fdashboard%2Fjs%2F732ce617825a.js%3A793%3A58) at https://myhelion.test/static/dashboard/js/732ce617825a.js:699:8 at https://myhelion.test/static/dashboard/js/732ce617825a.js:927:7 at forEach (https://myhelion.test/static/dashboard/js/732ce617825a.js:703:400) at loadModules (https://myhelion.test/static/dashboard/js/732ce617825a.js:924:156) at createInjector (https://myhelion.test/static/dashboard/js/732ce617825a.js:913:464) at doBootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:792:36) at bootstrap (https://myhelion.test/static/dashboard/js/732ce617825a.js:793:58) at angularInit (https://myhelion.test/static/dashboard/js/732ce617825a.js:789:556) at HTMLDocument.<anonymous> (https://myhelion.test/static/dashboard/js/732ce617825a.js:1846:1383) at fire (https://myhelion.test/static/dashboard/js/732ce617825a.js:208:299) To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1754133/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp