Reviewed: https://review.openstack.org/568304 Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f37895dc59f7bc2127b4e1ba8e38ab50e3f1f9cb Submitter: Zuul Branch: master
commit f37895dc59f7bc2127b4e1ba8e38ab50e3f1f9cb Author: Lance Bragstad <lbrags...@gmail.com> Date: Mon May 14 14:29:52 2018 +0000 Update tests to work with WebOb 1.8.1 WebOb recently changed how they validate Accept-* headers [0] to closely follow the definitions in RFC 7231 Section 5.3.2 [1]. WebOb now checks the actual value of the Accept-Language header and compares it to a regular expression. This caused a couple keystone unit tests to fail because we were generating random UUIDs for Accept-Language testing just to make sure the logic within keystone was behaving properly. The UUID format actual fails the new regular expression being used by WebOb to validate the Accept-Language header. This commit changes the tests to use a language header that passes the new validation put in place by WebOb. [0] https://docs.pylonsproject.org/projects/webob/en/stable/whatsnew-1.8.html#backwards-incompatibilities [1] https://tools.ietf.org/html/rfc7231.html#section-5.3.2 Change-Id: Ic53f4d00bc6c8dec08ec1bff589a91ff359276e1 Closes-Bug: 1765748 ** Changed in: keystone Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1765748 Title: webob-1.8.1 breaks projects Status in Glance: Fix Released Status in OpenStack Identity (keystone): Fix Released Status in OpenStack Compute (nova): In Progress Status in OpenStack Global Requirements: In Progress Bug description: Stuff like this ft2.2: glance.tests.unit.common.test_wsgi.ResourceTest.test_translate_exception_StringException: Traceback (most recent call last): File "/home/zuul/src/git.openstack.org/openstack/glance/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1297, in patched arg = patching.__enter__() File "/home/zuul/src/git.openstack.org/openstack/glance/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1369, in __enter__ original, local = self.get_original() File "/home/zuul/src/git.openstack.org/openstack/glance/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1343, in get_original "%s does not have the attribute %r" % (target, name) AttributeError: <class 'webob.acceptparse.AcceptLanguage'> does not have the attribute 'best_match' To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1765748/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp