Reviewed: https://review.openstack.org/571702 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=61a79a9b7a2c6421381a36ec4c3c2dc27681626a Submitter: Zuul Branch: master
commit 61a79a9b7a2c6421381a36ec4c3c2dc27681626a Author: vmarkov <vmar...@mirantis.com> Date: Fri Jun 1 13:56:56 2018 +0300 Show WEBSSO disclaimer only when it is needed Horizon can support several auth mechanisms, i.e. Keystone creds and OpenID. User allowed to choose proper way of auth and disclaimer is shown. But it is possible to allow choose from the only variant, and in this case disclaimer also shown, which is confusing. Proposed patch fix disclaimer display and makes it reasonable Closes-bug: #1774623 Change-Id: Ib039c6fdf1e4cd21b5ebe426fe2a15355a37353c ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1774623 Title: Remove unnecessary disclaimer from the login page Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Horizon has WEBSSO_CHOICES config option which allows user to select auth mechanism to login, like Keystone credentials or OpenID. List of valid auth choices also is configurable. If this option is enabled, user gets list of auth variants and disclaimer "If you are not sure which authentication method to use, contact your administrator". Disclaimer is shown even if list has only one possible option, which is confusing. Way to reproduce: Enable WEBSSO_ENABLED and WEBSSO_CHOICES options in Horizon config and make WEBSSO_CHOICES include exactly one element To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1774623/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp