Reviewed: https://review.openstack.org/643194 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=86b3993ceec0c64f4aed02a498fc747ce91eb682 Submitter: Zuul Branch: master
commit 86b3993ceec0c64f4aed02a498fc747ce91eb682 Author: Takashi NATSUME <natsume.taka...@lab.ntt.co.jp> Date: Thu Mar 14 09:05:21 2019 +0900 Fix misuse of assertTrue/assertFalse Change-Id: I247705feeb71e20ad5260b0ca1da08de7290ba6e Closes-Bug: #1819982 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1819982 Title: Misuse of assertTrue/assertFalse Status in neutron: Fix Released Bug description: There are some misuse of assertTrue/assertFalse in unit tests. They should be fixed. https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/services/placement_report/test_plugin.py#L191 self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L170 self.assertFalse(event, None) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L236 self.assertFalse(send_events.called, False) To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1819982/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp