Public bug reported:

Recently added change to ironic notifier plugin migrated the client connection 
from ironicclient to openstacksdk. The change in the unit tests didn't take 
into consideration that the openstacksdk exceptions method raise_from_response 
evaluates the response code as int and this may cause random errors bypassed 
during tests.
An example can be seen here:
https://zuul.opendev.org/t/openstack/build/943c3f89519c44a58e0b5c86ad4efff8/log/job-output.txt#23782-23789

Important note:
this bug doesn't affect any operational part of the code but just the unit 
tests.

** Affects: neutron
     Importance: Undecided
     Assignee: Riccardo Pittau (rpittau)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1848147

Title:
  not mocking openstacksdk exception may cause random non detected
  errors in unit tests

Status in neutron:
  In Progress

Bug description:
  Recently added change to ironic notifier plugin migrated the client 
connection from ironicclient to openstacksdk. The change in the unit tests 
didn't take into consideration that the openstacksdk exceptions method 
raise_from_response evaluates the response code as int and this may cause 
random errors bypassed during tests.
  An example can be seen here:
  
https://zuul.opendev.org/t/openstack/build/943c3f89519c44a58e0b5c86ad4efff8/log/job-output.txt#23782-23789

  Important note:
  this bug doesn't affect any operational part of the code but just the unit 
tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1848147/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to